-
Notifications
You must be signed in to change notification settings - Fork 994
Doubly Robust Estimator #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doubly Robust Estimator #1346
Conversation
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
|
tagging @amit-sharma or @bloebp for review! |
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nparent1 sorry for the delay. This PR is an excellent addition --thank you for adding this. I especially appreciate the clear docstrings and the detailed description of the DR estimator in the notebook, which will be beneficial for new users trying out the method.
I just noticed that the notebooks contain output cells too. If you can clear out the output cells, I'd be happy to go ahead and merge.
docs/source/example_notebooks/dowhy_doubly_robust_estimator.ipynb
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicholas Parente <[email protected]>
Thanks for the review @amit-sharma! I just cleared the output cells (72dc236), so should be good to merge! |
Signed-off-by: Nicholas Parente <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks great now.
PR to add support for the doubly robust estimator, with an example notebook. This PR addresses issue #407.
References:
Michele Jonsson Funk, Daniel Westreich, Chris Wiesen, Til Stürmer, M. Alan Brookhart, Marie Davidian, Doubly Robust Estimation of Causa Effects, American Journal of Epidemiology, Volume 173, Issue 1 April 2011, Pages 761-767, https://doi.org/10.1093/aje/kwq439