Skip to content

Conversation

@nparent1
Copy link
Contributor

@nparent1 nparent1 commented Aug 25, 2025

PR to add support for the doubly robust estimator, with an example notebook. This PR addresses issue #407.

References:

Michele Jonsson Funk, Daniel Westreich, Chris Wiesen, Til Stürmer, M. Alan Brookhart, Marie Davidian, Doubly Robust Estimation of Causa Effects, American Journal of Epidemiology, Volume 173, Issue 1 April 2011, Pages 761-767, https://doi.org/10.1093/aje/kwq439

Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
@nparent1 nparent1 marked this pull request as ready for review August 27, 2025 04:21
@nparent1
Copy link
Contributor Author

tagging @amit-sharma or @bloebp for review!

Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nparent1 sorry for the delay. This PR is an excellent addition --thank you for adding this. I especially appreciate the clear docstrings and the detailed description of the DR estimator in the notebook, which will be beneficial for new users trying out the method.

I just noticed that the notebooks contain output cells too. If you can clear out the output cells, I'd be happy to go ahead and merge.

Signed-off-by: Nicholas Parente <[email protected]>
@nparent1
Copy link
Contributor Author

Hey @nparent1 sorry for the delay. This PR is an excellent addition --thank you for adding this. I especially appreciate the clear docstrings and the detailed description of the DR estimator in the notebook, which will be beneficial for new users trying out the method.

I just noticed that the notebooks contain output cells too. If you can clear out the output cells, I'd be happy to go ahead and merge.

Thanks for the review @amit-sharma! I just cleared the output cells (72dc236), so should be good to merge!

Signed-off-by: Nicholas Parente <[email protected]>
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks great now.

@amit-sharma amit-sharma merged commit 5b09eb2 into py-why:main Oct 26, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants